Thoughts on replacing with:

export function isValidAddress(address: string): boolean {
  try {
    ethers.getAddress(address)
  } catch (e) {
    return false
  }

  if (ethers.getAddress(address) === ethers.ZeroAddress) {
    return false
  }

  return true
}

?

Do you mean using the isValidAddress from @keep-network/hardhat-helpers or updating the implementation here?

@keep-network/hardhat-helpers is specific for @keep-network projects and is based on ethers v5.

no, no need to reference keep-network. Just use the ethers lib and add/replace a check in if (tbtc && isNonZeroAddress(tbtc.address)) with if (tbtc && isValidAddress(tbtc.address)). It's just to validate that the address should not only be zero, but it's actually valid as well. ethers lib will check it.

Thoughts on replacing with:

export function isValidAddress(address: string): boolean {
  try {
    ethers.getAddress(address)
  } catch (e) {
    return false
  }

  if (ethers.getAddress(address) === ethers.ZeroAddress) {
    return false
  }

  return true
}

?

Instead of try catch we can use isAddress from ethers:

export function isValidAddress(address: string): boolean {
 return (
    ethers.isAddress(address) &&
    ethers.getAddress(address) !== ethers.ZeroAddress
  )
}

We call ethers.getAddress(address) !== ethers.ZeroAddress, so the address is validated with ethers.getAddress.

I added tests to ensure it works as expected: 332d6a9

sounds good, then this function name is misleading a bit. It checks not only if the address is zero, but also other things.

I like the current name isNonZeroAddress. It describes what the function is used for: check if the address is a non-zero address.

Is the realpath an external or built-in function? After migrating to M2 this command doesn't work for me. If it's external we should mention how to install it in the README.

I'm on M2 and this script worked for me. However, I did the auto-migration from my old Mac copying everything, so maybe it also copied realpath. It's located in /usr/local/bin/realpath on my box.

🤔 Works on my machine™

Updated in 3a05a45

Non-blocking:

Maybe we should consider adding a prettier for sh files.

#75

It removes tmp/external-artifacts, but leaves tmp. We should remove root tmp and all the subfolders.

I intentionally left the main ./tmp directory in case it contains files from other processes. We remove only the ./tmp/external-artifacts directory that contains files relevant to this script.
The main ./tmp was added to .gitignore.

I intentionally left the main ./tmp directory in case it contains files from other processes.

Then how about adding -d flag to rm -d tmp? If it's non-empty then the command won't remove it. If empty, it will. Point is, this script can create a temporary dir on dev's box and if after running the script it's empty, then it will be nice to clean it as well. That's my final comment, if you think otherwise, leave it as-is.

I don't have strong feelings; I'd leave it as is for now and see if we find the current approach painful.
Please feel free to introduce any improvements to the script, though!